Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax go version requirements #438

Closed
wants to merge 2 commits into from

Conversation

AlCutter
Copy link
Collaborator

@AlCutter AlCutter commented Jan 9, 2025

This PR relaxes the go version requirement to allow users of the module to use any patch version of 1.22, with a local toolchain recommendation of 1.22.10.

Rationale similar to google/trillian#3713

@AlCutter AlCutter requested a review from phbnf January 9, 2025 15:57
@AlCutter
Copy link
Collaborator Author

AlCutter commented Jan 9, 2025

Ah, nm, we can't because grpc:

go: go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc@v0.58.0 requires go@1.22.7, but 1.22.0 is requested

@AlCutter AlCutter closed this Jan 9, 2025
@dnwe
Copy link

dnwe commented Jan 9, 2025

@AlCutter yeah, this is the unfortunate behaviour of the go directive — you get forced to use the maximum found across all of your dependencies, so as soon as someone has set a higher version you all have to bump up to match. I don't really know why the Go team permitted/required a full major.minor.patch as it has led to a lot of confusion amongst module developers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants