Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage API uses partial width rather than logSize #393

Merged
merged 12 commits into from
Dec 9, 2024

Conversation

AlCutter
Copy link
Collaborator

@AlCutter AlCutter commented Dec 6, 2024

This PR replaces the use of logSize on the exported storage APIs with the explicit desired partial tile/entry bundle size.

There are different classes of users of these APIs which will naturally favour one these approaches (e.g. clients must have a checkpoint in their possession and so always know the log's size), but whereas it's trivial to go from logSize to the implied partial tile/entry bundle width, the inverse is not.

This PR redresses the imbalance by flipping over to using partial tile widths where appropriate, and exporting the function for calculating partial tile widths from tile coordinate and log size.

api/layout/paths.go Outdated Show resolved Hide resolved
api/layout/tile.go Outdated Show resolved Hide resolved
@mhutchinson
Copy link
Contributor

There's a conflict between this and #398, but it's an easy fix.

@AlCutter AlCutter merged commit ea9eac7 into transparency-dev:main Dec 9, 2024
15 checks passed
@AlCutter AlCutter deleted the partial_not_size branch December 9, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants