-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storage API uses partial width rather than logSize #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlCutter
force-pushed
the
partial_not_size
branch
from
December 6, 2024 15:30
2d2ae32
to
fe8cbc2
Compare
mhutchinson
approved these changes
Dec 9, 2024
AlCutter
force-pushed
the
partial_not_size
branch
from
December 9, 2024 11:29
fe8cbc2
to
a62eadf
Compare
There's a conflict between this and #398, but it's an easy fix. |
AlCutter
force-pushed
the
partial_not_size
branch
from
December 9, 2024 12:02
a62eadf
to
51a6b41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the use of
logSize
on the exported storage APIs with the explicit desired partial tile/entry bundle size.There are different classes of users of these APIs which will naturally favour one these approaches (e.g. clients must have a checkpoint in their possession and so always know the log's size), but whereas it's trivial to go from
logSize
to the implied partial tile/entry bundle width, the inverse is not.This PR redresses the imbalance by flipping over to using partial tile widths where appropriate, and exporting the function for calculating partial tile widths from tile coordinate and log size.