[MySQL Conformance] fix tree size bug #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is also a bug in the trillian-tessera/storage/mysql/mysql_test.go Lines 288 to 289 in 26d8567 |
mhutchinson
force-pushed
the
b364-fixmySqlConformance
branch
2 times, most recently
from
73d6d85 to
5f73ad1
Compare
roger2hk
reviewed
Dec 5, 2024
mhutchinson
force-pushed
the
b364-fixmySqlConformance
branch
2 times, most recently
from
294e991 to
4f05e57
Compare
mhutchinson
force-pushed
the
b364-fixmySqlConformance
branch
from
4f05e57 to
6103bee
Compare
roger2hk
reviewed
Dec 5, 2024
AlCutter
approved these changes
Dec 5, 2024
roger2hk
approved these changes
Dec 5, 2024
Major changes: - MySQL storage read methods return os.ErrNotExist when values aren't found - ReadTile returns an error if the user requests more data than we have available - Added tests for writing and reading data from tiles - Made tests hermetic (though slower) by resetting the DB for each test case This got a bit bigger than intended.
mhutchinson
force-pushed
the
b364-fixmySqlConformance
branch
from
693ba17 to
a09c4b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major changes:
This got a bit bigger than intended.
This fixes #364.