More GCP #35
Merged
More GCP #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phbnf
reviewed
Jul 8, 2024
phbnf
approved these changes
Jul 8, 2024
storage/gcp/gcp_test.go
Outdated
| index uint64 | ||
| logSize uint64 | ||
| tileSize uint64 | ||
| wantErr bool |
There was a problem hiding this comment.
did you mean to add a test with wantErr and a non existing tile?
There was a problem hiding this comment.
Good question - I think I started with that intention and then figured that since this is a round-trip test, there shouldn't really be any errors so I've removed the bool.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for reading and writing to GCS.
Toward #23.