[GCP] Make the GCP conformance deployment config more friendly #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roger2hk
reviewed
Nov 29, 2024
roger2hk
reviewed
Nov 29, 2024
Comment on lines
50
to
63
| ```bash | ||
| $ gcloud artifacts repositories create ${DOCKER_REPO_NAME} \ | ||
| --repository-format=docker \ | ||
| --location=us-central1 \ | ||
| --description="My Tessera docker repo" \ | ||
| --immutable-tags | ||
|
|
||
| $ gcloud auth configure-docker us-central1-docker.pkg.dev | ||
|
|
||
| $ docker build . -f ./cmd/conformance/gcp/Dockerfile --tag us-central1-docker.pkg.dev/${YOUR_GCP_PROJECT}/${DOCKER_REPO_NAME}/conformance:latest | ||
|
|
||
| $ docker push us-central1-docker.pkg.dev/${YOUR_GCP_PROJECT}/${DOCKER_REPO_NAME}/conformance:latest | ||
|
|
||
| ``` |
There was a problem hiding this comment.
Remove the leading $ for easy copy & paste.
Comment on lines
10
to
14
| inputs = merge( | ||
| include.root.locals, | ||
| { | ||
| server_docker_image = "us-central1-docker.pkg.dev/trillian-tessera/docker-prod/conformance-gcp:latest" | ||
| } | ||
| ) |
There was a problem hiding this comment.
Is the merge() still needed when server_docker_image is removed?
There was a problem hiding this comment.
Not as is, but I left that there in case someone wanted to make overrides specifically for CI.
roger2hk
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the
terra{grunt,form}config for deploying the GCP conformance environment more friendly for humans to use when exploring Tessera.The main changes are: