-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MySQL] Separate integration from publishing checkpoints #344
[MySQL] Separate integration from publishing checkpoints #344
Conversation
61d0169
to
0bcef71
Compare
0bcef71
to
595f2ee
Compare
262fdbe
to
e756f77
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we align the wrapped error? Some of them are wrapped %w
while some of them are not %v
.
No, don't use |
e756f77
to
f1e3f98
Compare
f1e3f98
to
cff89e9
Compare
Right, I see some of the error messages are using |
Yeah, there seems to be a mix throughout the file so probably needs some time to think about why they were added. |
This PR disconnects the act of integrating new entries into a tree, from the act of publishing a new checkpoint which publicly commits to that new tree state for the MySQL storage implementation.
See #323 for more details on the rationale.
Helps with #309 and #198.