Break ground on the GCP implementation #29
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| terraform { | ||
| source = "${get_repo_root()}/deployment/modules/gcs" | ||
| } | ||
|
|
||
| locals { | ||
| project_id = "trillian-tessera" | ||
| location = "us-central1" | ||
| base_name = "example-gcs" | ||
| } | ||
|
There was a problem hiding this comment. nit: Formatting is a bit dodgy. |
||
|
|
||
| inputs = merge( | ||
| local, | ||
| {} | ||
| ) | ||
|
|
||
| remote_state { | ||
| backend = "gcs" | ||
|
|
||
| config = { | ||
| project = local.project_id | ||
| location = local.location | ||
| bucket = "${local.project_id}-${local.base_name}-terraform-state" | ||
|
|
||
| gcs_bucket_labels = { | ||
| name = "terraform_state_storage" | ||
| } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,73 @@ | ||||||
| terraform { | ||||||
| backend "gcs" {} | ||||||
| } | ||||||
|
|
||||||
| # Services | ||||||
| resource "google_project_service" "serviceusage_googleapis_com" { | ||||||
| service = "serviceusage.googleapis.com" | ||||||
|
There was a problem hiding this comment. Consider https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/google_project_service#disable_on_destroy - I've used this elsewhere as it seems safer. |
||||||
| } | ||||||
| resource "google_project_service" "storage_api_googleapis_com" { | ||||||
| service = "storage-api.googleapis.com" | ||||||
| } | ||||||
| resource "google_project_service" "storage_component_googleapis_com" { | ||||||
| service = "storage-component.googleapis.com" | ||||||
| } | ||||||
| resource "google_project_service" "storage_googleapis_com" { | ||||||
| service = "storage.googleapis.com" | ||||||
| } | ||||||
|
|
||||||
| ## Resources | ||||||
|
|
||||||
| # Service accounts | ||||||
|
|
||||||
| resource "google_service_account" "log_writer" { | ||||||
| account_id = "${var.base_name}-writer" | ||||||
| display_name = "Log writer service account" | ||||||
|
There was a problem hiding this comment.
Suggested change
Just to put it in somewhere that this isn't metrics/stackdriver logs, but tlogs. |
||||||
| } | ||||||
|
|
||||||
|
|
||||||
| # Buckets | ||||||
|
|
||||||
| resource "google_storage_bucket" "log_bucket" { | ||||||
| name = "${var.project_id}-${var.base_name}-bucket" | ||||||
| location = var.location | ||||||
| storage_class = "STANDARD" | ||||||
| uniform_bucket_level_access = true | ||||||
| } | ||||||
|
|
||||||
| resource "google_storage_bucket_iam_binding" "log_bucket_writer" { | ||||||
| bucket = google_storage_bucket.log_bucket.name | ||||||
| role = "roles/storage.legacyBucketWriter" | ||||||
| members = [ | ||||||
| google_service_account.log_writer.member | ||||||
| ] | ||||||
| } | ||||||
|
|
||||||
| # Spanner | ||||||
|
|
||||||
| resource "google_spanner_instance" "log_spanner" { | ||||||
| name = var.base_name | ||||||
| config = "regional-${var.location}" | ||||||
| display_name = "${var.base_name} Spanner Instance" | ||||||
| processing_units = 100 | ||||||
| } | ||||||
|
|
||||||
| resource "google_spanner_database" "log_db" { | ||||||
|
There was a problem hiding this comment. We may want to look at using something like https://github.com/golang-migrate/migrate/tree/master/database/spanner to manage this when we do it for realz. This will be painful if this schema ever needs to be updated. I used to mysql version of this library for the experiments and it was cool. |
||||||
| instance = google_spanner_instance.log_spanner.name | ||||||
| name = "${var.base_name}-db" | ||||||
| ddl = [ | ||||||
| "CREATE TABLE SeqCoord (id INT64 NOT NULL, next INT64 NOT NULL,) PRIMARY KEY (id)", | ||||||
| "CREATE TABLE Seq (id INT64 NOT NULL, seq INT64 NOT NULL, v BYTES(MAX),) PRIMARY KEY (id, seq)", | ||||||
| "CREATE TABLE IntCoord (id INT64 NOT NULL, seq INT64 NOT NULL,) PRIMARY KEY (id)", | ||||||
| ] | ||||||
| } | ||||||
|
|
||||||
| resource "google_spanner_database_iam_binding" "database" { | ||||||
| instance = google_spanner_instance.log_spanner.name | ||||||
| database = google_spanner_database.log_db.name | ||||||
| role = "roles/spanner.databaseUser" | ||||||
|
|
||||||
| members = [ | ||||||
| google_service_account.log_writer.member | ||||||
| ] | ||||||
| } | ||||||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| output "log_bucket" { | ||
|
There was a problem hiding this comment. Do you want to output the spanner resource too as that's needed for the binary? |
||
| description = "Log GCS bucket" | ||
| value = google_storage_bucket.log_bucket | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| variable "project_id" { | ||
| description = "GCP project ID where the log is hosted" | ||
| type = string | ||
| } | ||
|
|
||
| variable "base_name" { | ||
| description = "Base name to use when naming resources" | ||
|
There was a problem hiding this comment. This docstring is a bit unclear and leaves some guesswork (or detective work, more likely). |
||
| type = string | ||
| } | ||
|
|
||
| variable "location" { | ||
| description = "Location in which to create resources" | ||
| type = string | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: maybe intentional, but the one character difference between this and the directory name is a bit offputting (gcp vs gcs).