Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Squash duplicate errors in hammer #250

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

AlCutter
Copy link
Collaborator

@AlCutter AlCutter commented Sep 12, 2024

This PR "squashes" duplicate errors printed out by the hammer.

When there's an error talking to the target log, the hammer logs the error as a Warn entry.
In theory this is great, but in practice errors tend to come in floods which has the unfortunate effect of making it hard to see what's going on because there's a flood of error messages whipping past.

This PR turns a run of identical errors into a single line with a count:

W0912 14:44:46.326227 463 hammer.go:341] (129 x) failed to create request: write leaf was not OK. Status code: 500. Body: ...

@AlCutter AlCutter requested a review from roger2hk September 12, 2024 14:57
@AlCutter AlCutter marked this pull request as ready for review September 12, 2024 14:57
@AlCutter AlCutter merged commit a984f59 into transparency-dev:main Sep 12, 2024
14 checks passed
@AlCutter AlCutter deleted the shhh_hammer branch September 12, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants