Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove keys from the config, and delete the config proto #234

Merged
merged 10 commits into from
Sep 9, 2024
Merged

Remove keys from the config, and delete the config proto #234

merged 10 commits into from
Sep 9, 2024

Conversation

phbnf
Copy link
Contributor

@phbnf phbnf commented Sep 9, 2024 •
edited
Loading

Toward #200 and #88

This PR:

  • Deletes the public key from configs, it's not used for anything
  • Moves the private key away from the config file to a .pem file. This is not the end state, it will be changed later, but this is a handy intermediary step.
  • Deletes multiple key handlers
  • Deletes the sctfe config, everything is now passed through flags!
  • Few nits

@phbnf phbnf force-pushed the removekeys branch 2 times, most recently from 346e42c to d72fd2b Compare September 9, 2024 13:38
@phbnf phbnf marked this pull request as ready for review September 9, 2024 13:39
@phbnf phbnf merged commit ed925d1 into transparency-dev:main Sep 9, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlCutter AlCutter AlCutter approved these changes

Assignees

@AlCutter AlCutter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phbnf @AlCutter