remove root_pem_file from cfg, and only allow a single file #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlCutter
approved these changes
Sep 6, 2024
personalities/sctfe/config.go
Outdated
| @@ -48,9 +48,9 @@ type LogConfig struct { | |||
| // origin identifies the log. It will be used in its checkpoint, and | |||
| // is also its submission prefix, as per https://c2sp.org/static-ct-api | |||
| Origin string | |||
| // Paths to the files containing root certificates that are acceptable to the | |||
| // Paths to the file containing root certificates that are acceptable to the | |||
There was a problem hiding this comment.
Suggested change
| // Paths to the file containing root certificates that are acceptable to the | |
| // Path to the file containing root certificates that are acceptable to the |
| projectID = flag.String("project_id", "", "origin of the log, for checkpoints and the monitoring prefix") | ||
| bucket = flag.String("bucket", "", "name of the bucket to store the log in") | ||
| spannerDB = flag.String("spanner_db_path", "", "projects/{projectId}/instances/{instanceId}/databases/{databaseId}") | ||
| rootsPemFile = flag.String("roots_pem_file", "", "Paths to the file containing root certificates that are acceptable to the log. The certs are served through get-roots endpoint.") |
There was a problem hiding this comment.
Suggested change
| rootsPemFile = flag.String("roots_pem_file", "", "Paths to the file containing root certificates that are acceptable to the log. The certs are served through get-roots endpoint.") | |
| rootsPemFile = flag.String("roots_pem_file", "", "Path to the file containing root certificates that are acceptable to the log. The certs are served through get-roots endpoint.") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #200 and #88.
This PR does two things:
Leaving a TODO to move the roots_pem_file check rather than deleting in this PR because I've already done it further down in the chain of commits, but rebasing these commits is a bit of a pain with all the tests.