Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix partial tile clean up #187

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

AlCutter
Copy link
Collaborator

This PR fixes an error in the partial tile clean up code.

Previously the code expected to find partial tiles named as <tileID>.<size>, but the tlog-tiles spec requires partial tiles to be stored in a directory named <tileID>.p/. This resulted in errors like the one below when the storage implementation completed a full tile:

E0830 11:39:00.756914  239314 files.go:225] Integrate failed: failed to set tile({0 0}): failed to rename temp link over partial tile: rename /tmp/mylog/tile/0/000.link /tmp/mylog/tile/0/000.p: file exists

This PR fixes the incorrect path assumption.

@AlCutter AlCutter added the bug Something isn't working label Aug 30, 2024
@AlCutter AlCutter requested a review from roger2hk August 30, 2024 11:50
@AlCutter AlCutter merged commit 1ab79d3 into transparency-dev:main Aug 30, 2024
10 checks passed
@AlCutter AlCutter deleted the fix_posix_cleanup branch August 30, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants