Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample personality library proof-of-concept #156

Closed
wants to merge 1 commit into from

Conversation

roger2hk
Copy link
Contributor

@roger2hk roger2hk commented Aug 20, 2024

This is a proof-of-concept pull request to illustrate the idea of personality library. This helps the team decide whether a library for the sample personality is needed.

@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 65 lines in your changes missing coverage. Please review.

Project coverage is 35.00%. Comparing base (46ec9c2) to head (a5d575c).
Report is 72 commits behind head on main.

Files Patch % Lines
cmd/example-mysql/main.go 0.00% 30 Missing ⚠️
cmd/example-gcp/main.go 0.00% 25 Missing ⚠️
personalities/sample/sample.go 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #156      +/-   ##
==========================================
- Coverage   35.80%   35.00%   -0.81%     
==========================================
  Files          16       34      +18     
  Lines        1363     2897    +1534     
==========================================
+ Hits          488     1014     +526     
- Misses        801     1773     +972     
- Partials       74      110      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roger2hk roger2hk force-pushed the sample-personality branch from 428a37b to a5d575c Compare August 20, 2024 19:41
@roger2hk
Copy link
Contributor Author

roger2hk commented Sep 4, 2024

Closing this pull request as it has served its purpose.

@roger2hk roger2hk closed this Sep 4, 2024
@roger2hk roger2hk deleted the sample-personality branch September 4, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants