Set content type appropriately #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to initialize the writer before setting the content type
AlCutter
approved these changes
Aug 19, 2024
| if cond == nil { | ||
| w = obj.NewWriter(ctx) | ||
|
|
||
| } else { | ||
| w = obj.If(*cond).NewWriter(ctx) | ||
| } | ||
| w.ObjectAttrs.ContentType = contType |
There was a problem hiding this comment.
Ah, yes - that seems like a better location :)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #151 +/- ##
==========================================
+ Coverage 35.80% 36.00% +0.19%
==========================================
Files 16 32 +16
Lines 1363 2811 +1448
==========================================
+ Hits 488 1012 +524
- Misses 801 1688 +887
- Partials 74 111 +37 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to initialize the writer before setting the content type