Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dockerfile for example-gcp #145

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

AlCutter
Copy link
Collaborator

@AlCutter AlCutter commented Aug 16, 2024

This PR adds a simple Dockerfile for building the example-gcp binary.

Eventually, this can be used for CI/CD testing on GCP.

Towards #7.

@AlCutter AlCutter requested a review from phbnf August 16, 2024 12:43
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.01%. Comparing base (46ec9c2) to head (196dcdc).
Report is 62 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #145      +/-   ##
==========================================
+ Coverage   35.80%   36.01%   +0.20%     
==========================================
  Files          16       33      +17     
  Lines        1363     2824    +1461     
==========================================
+ Hits          488     1017     +529     
- Misses        801     1697     +896     
- Partials       74      110      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phbnf
Copy link
Contributor

phbnf commented Aug 16, 2024

Ran docker build -f ./cmd/example-gcp/Dockerfile . successfully

@AlCutter AlCutter merged commit 8410ce4 into transparency-dev:main Aug 16, 2024
8 checks passed
@AlCutter AlCutter deleted the example_gcp_docker branch August 16, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants