Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for the hammer analysis #137

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

mhutchinson
Copy link
Contributor

Basic tests to make sure that the average reported is correct and that
async behaviour is reliable.

Basic tests to make sure that the average reported is correct and that
async behaviour is reliable.
Both the test and the analysis code under test had race unsafe code
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 76.47059% with 4 lines in your changes missing coverage. Please review.

Project coverage is 36.41%. Comparing base (46ec9c2) to head (1d0c657).
Report is 55 commits behind head on main.

Files Patch % Lines
hammer/hammer.go 81.25% 2 Missing and 1 partial ⚠️
hammer/tui.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #137      +/-   ##
==========================================
+ Coverage   35.80%   36.41%   +0.60%     
==========================================
  Files          16       33      +17     
  Lines        1363     2793    +1430     
==========================================
+ Hits          488     1017     +529     
- Misses        801     1666     +865     
- Partials       74      110      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mhutchinson mhutchinson requested a review from AlCutter August 14, 2024 11:37
@mhutchinson mhutchinson merged commit a9fe306 into transparency-dev:main Aug 14, 2024
7 checks passed
@mhutchinson mhutchinson deleted the hammer-analysisTests branch August 14, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants