Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove issuance chain cache #127

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Conversation

phbnf
Copy link
Contributor

@phbnf phbnf commented Aug 8, 2024

This was added to the CTFE to cache individual certs in the issuance chain. We don't need this anymore since the SCTFE won't serve issuance chain certs anymore, at least not with bucket styled storage system.

@phbnf phbnf requested a review from roger2hk August 8, 2024 13:36
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 34.99%. Comparing base (46ec9c2) to head (1332697).
Report is 46 commits behind head on main.

Files Patch % Lines
personalities/sctfe/ct_server_gcp/main.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
- Coverage   35.80%   34.99%   -0.81%     
==========================================
  Files          16       33      +17     
  Lines        1363     2706    +1343     
==========================================
+ Hits          488      947     +459     
- Misses        801     1652     +851     
- Partials       74      107      +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phbnf phbnf merged commit d2a7cc7 into transparency-dev:main Aug 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants