Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split the analysis out of the hammer #125

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

mhutchinson
Copy link
Contributor

Separating the experimentation from the measurement makes it easier to understand the code and avoid the hammer growing into a monolith.

Separating the experimentation from the measurement makes it easier to understand the code and avoid the hammer growing into a monolith.
@mhutchinson mhutchinson requested a review from roger2hk August 7, 2024 16:26
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 59 lines in your changes missing coverage. Please review.

Project coverage is 34.79%. Comparing base (46ec9c2) to head (6de1416).
Report is 45 commits behind head on main.

Files Patch % Lines
hammer/hammer.go 0.00% 44 Missing ⚠️
hammer/tui.go 0.00% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #125      +/-   ##
==========================================
- Coverage   35.80%   34.79%   -1.02%     
==========================================
  Files          16       33      +17     
  Lines        1363     2722    +1359     
==========================================
+ Hits          488      947     +459     
- Misses        801     1668     +867     
- Partials       74      107      +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

hammer/tui.go Show resolved Hide resolved
@mhutchinson mhutchinson merged commit 2ff487d into transparency-dev:main Aug 14, 2024
6 checks passed
@mhutchinson mhutchinson deleted the hammer-splitAnalysis branch August 14, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants