-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Go tests in MySQL storage implementation #110
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #110 +/- ##
==========================================
- Coverage 35.80% 28.62% -7.18%
==========================================
Files 16 31 +15
Lines 1363 2683 +1320
==========================================
+ Hits 488 768 +280
- Misses 801 1828 +1027
- Partials 74 87 +13 ☔ View full report in Codecov by Sentry. |
Would the |
AlCutter
reviewed
Aug 2, 2024
roger2hk
force-pushed
the
mysql-add-tests
branch
from
August 2, 2024 20:17
c7cbeca
to
e80e41c
Compare
mhutchinson
reviewed
Aug 5, 2024
….New()` method comment
roger2hk
force-pushed
the
mysql-add-tests
branch
from
August 6, 2024 22:30
1bf797e
to
64eb6fc
Compare
mhutchinson
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#21
Note that this pull request also makes
tessera.WithCheckpointSignerVerifier
optional inmysql.New()
because the issue was found during the tests development.