Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Go tests in MySQL storage implementation #110

Merged
merged 12 commits into from
Aug 7, 2024

Conversation

roger2hk
Copy link
Contributor

@roger2hk roger2hk commented Aug 1, 2024

#21

Note that this pull request also makes tessera.WithCheckpointSignerVerifier optional in mysql.New() because the issue was found during the tests development.

@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.62%. Comparing base (46ec9c2) to head (80aeb03).
Report is 36 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #110      +/-   ##
==========================================
- Coverage   35.80%   28.62%   -7.18%     
==========================================
  Files          16       31      +15     
  Lines        1363     2683    +1320     
==========================================
+ Hits          488      768     +280     
- Misses        801     1828    +1027     
- Partials       74       87      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roger2hk
Copy link
Contributor Author

roger2hk commented Aug 2, 2024

Would the 655536 be too large in the TestParallelAdd test?

storage/mysql/mysql_test.go Show resolved Hide resolved
storage/mysql/mysql_test.go Outdated Show resolved Hide resolved
storage/mysql/mysql_test.go Outdated Show resolved Hide resolved
storage/mysql/mysql_test.go Outdated Show resolved Hide resolved
storage/mysql/mysql_test.go Outdated Show resolved Hide resolved
storage/mysql/mysql_test.go Show resolved Hide resolved
storage/mysql/mysql_test.go Outdated Show resolved Hide resolved
storage/mysql/mysql.go Show resolved Hide resolved
@roger2hk roger2hk requested a review from AlCutter August 2, 2024 21:55
storage/mysql/mysql_test.go Outdated Show resolved Hide resolved
storage/mysql/mysql.go Outdated Show resolved Hide resolved
@roger2hk roger2hk requested a review from mhutchinson August 6, 2024 22:54
@roger2hk roger2hk merged commit cbfe1de into transparency-dev:main Aug 7, 2024
6 checks passed
@roger2hk roger2hk deleted the mysql-add-tests branch August 7, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants