Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sequence and integrate in MySQL storage implementation #102

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

roger2hk
Copy link
Contributor

#21

This PR fixes the panic error when adding new entry to a zero-size log. There is a TODO to modify the query (probably use left outer join)/logic if the given tileIDs are not sorted and may not exist.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 31.05%. Comparing base (46ec9c2) to head (b9cc9e3).
Report is 21 commits behind head on main.

Files Patch % Lines
storage/mysql/mysql.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #102      +/-   ##
==========================================
- Coverage   35.80%   31.05%   -4.75%     
==========================================
  Files          16       16              
  Lines        1363     1565     +202     
==========================================
- Hits          488      486       -2     
- Misses        801     1005     +204     
  Partials       74       74              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roger2hk roger2hk merged commit 7281cfd into transparency-dev:main Aug 1, 2024
5 checks passed
@roger2hk roger2hk deleted the mysql-fix-sequence branch August 1, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants