Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sequence and integrate in MySQL storage implementation #101

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Fix sequence and integrate in MySQL storage implementation #101

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions storage/mysql/mysql.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,11 +259,14 @@ func (s *Storage) sequenceBatch(ctx context.Context, entries []*tessera.Entry) e
// integrate incorporates the provided entries into the log starting at fromSeq.
func (s *Storage) integrate(ctx context.Context, tx *sql.Tx, fromSeq uint64, entries []*tessera.Entry) error {
tb := storage.NewTreeBuilder(func(ctx context.Context, tileIDs []storage.TileID, treeSize uint64) ([]*api.HashTile, error) {
hashTiles := make([]*api.HashTile, len(tileIDs))
hashTiles := make([]*api.HashTile, 0, len(tileIDs))
if len(tileIDs) == 0 {
return hashTiles, nil
}

// Build the SQL and args to fetch the hash tiles.
var sql strings.Builder
args := make([]uint64, 0, len(tileIDs)*2)
args := make([]any, 0, len(tileIDs)*2)
for i, id := range tileIDs {
if i != 0 {
sql.WriteString(" UNION ALL ")
Expand All @@ -275,7 +278,7 @@ func (s *Storage) integrate(ctx context.Context, tx *sql.Tx, fromSeq uint64, ent
args = append(args, id.Level, id.Index)
}

rows, err := tx.QueryContext(ctx, sql.String(), args)
rows, err := tx.QueryContext(ctx, sql.String(), args...)
if err != nil {
return nil, fmt.Errorf("failed to query the hash tiles with SQL (%s): %w", sql.String(), err)
}
Expand Down
Loading