Skip to content

Commit

Permalink
Update TODO comments
Browse files Browse the repository at this point in the history
  • Loading branch information
roger2hk committed Jul 22, 2024
1 parent 67a032e commit 8c016a0
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions cmd/example-mysql/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,7 @@ func main() {

entryBundle, err := storage.ReadEntryBundle(r.Context(), index)
if err != nil {
// TODO: Move this error back into storage implementation.
if err == sql.ErrNoRows {
w.WriteHeader(http.StatusNotFound)
return
Expand All @@ -124,10 +125,7 @@ func main() {
return
}

// TODO: when the number of entries in the returned tile match the requested tile width.
// This ensures the response will not be cached when returning a partial tile on a full tile request.

// TODO: Add immutable Cache-Control header
// TODO: Add immutable Cache-Control header.

if _, err := w.Write(entryBundle); err != nil {
klog.Errorf("/tile/entries/{index...}: %v", err)
Expand Down

0 comments on commit 8c016a0

Please sign in to comment.