Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove env vars for log signing keys. #58

Merged
merged 2 commits into from
Dec 14, 2023
Merged

Remove env vars for log signing keys. #58

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01f4ae2
Remove env vars for log signing keys.
jiggoha Dec 14, 2023
6f84456
Remove key pair generation instructions.
jiggoha Dec 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions experimental/gcp-log/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,6 @@ Both functions are HTTP-triggered and run when their respective endpoints are re

### GCF function deployment

1. Generate a set of public and private keys following
[these](https://github.com/transparency-dev/serverless-log/tree/master/serverless#generating-keys)
instructions and set them as the `PUBLIC_KEY` and `PRIVATE_KEY`.
1. Set `PROJECT_NAME` as the name of your GCP project (string, not number).
1. Deploy the Integrate function:

Expand All @@ -36,7 +33,7 @@ Both functions are HTTP-triggered and run when their respective endpoints are re
--entry-point Integrate \
--runtime go120 \
--trigger-http \
--set-env-vars "GCP_PROJECT=${PROJECT_NAME},SERVERLESS_LOG_PUBLIC_KEY=${PUBLIC_KEY},SERVERLESS_LOG_PRIVATE_KEY=${PRIVATE_KEY}" \
--set-env-vars "GCP_PROJECT=${PROJECT_NAME}" \
--source=./experimental/gcp-log \
--max-instances 1
```
Expand All @@ -48,7 +45,7 @@ Both functions are HTTP-triggered and run when their respective endpoints are re
--entry-point Sequence \
--runtime go120 \
--trigger-http \
--set-env-vars "GCP_PROJECT=${PROJECT_NAME},SERVERLESS_LOG_PUBLIC_KEY=${PUBLIC_KEY}" \
--set-env-vars "GCP_PROJECT=${PROJECT_NAME}" \
--source=./experimental/gcp-log \
--max-instances 1
```
Expand Down Expand Up @@ -79,7 +76,7 @@ Set up a log and write to the log via GCF invocation.
"kmsKeyName": "${KMS_KEY_NAME}",
"kmsKeyVersion": ${KMS_KEY_VERSION},
"kmsKeyLocation": "${KMS_KEY_LOCATION}",
"noteKeyName": "${NOTE_SIGNING_NAME}",
"noteKeyName": "${NOTE_SIGNING_NAME}"
}'
```

Expand All @@ -105,6 +102,6 @@ Set up a log and write to the log via GCF invocation.
"kmsKeyName": "${KMS_KEY_NAME}",
"kmsKeyVersion": ${KMS_KEY_VERSION},
"kmsKeyLocation": "${KMS_KEY_LOCATION}",
"noteKeyName": "${NOTE_SIGNING_NAME}",
"noteKeyName": "${NOTE_SIGNING_NAME}"
}'
```
Loading