Refactor reader/writer worker pools #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #154 +/- ##
===========================================
- Coverage 55.99% 27.43% -28.56%
===========================================
Files 8 16 +8
Lines 759 1498 +739
===========================================
- Hits 425 411 -14
- Misses 265 1008 +743
- Partials 69 79 +10 ☔ View full report in Codecov by Sentry. |
AlCutter
approved these changes
Jun 10, 2024
These were previously stored in raw slices. Now they are stored within the workerPool abstraction. This couples the ability to create a new worker with the pool, making growing and shrinking the number of workers easy. Support w/W keys for increasing/decreasing workers If this needs to be more granular then we can split this to different keys for changing the size of each of the 3 pools separately.
mhutchinson
force-pushed
the
hammerWorkerPools
branch
from
a692afb to
1bfda31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were previously stored in raw slices. Now they are stored within the workerPool abstraction. This couples the ability to create a new worker with the pool, making growing and shrinking the number of workers easy.
Support w/W keys for increasing/decreasing workers
If this needs to be more granular then we can split this to different
keys for changing the size of each of the 3 pools separately.