Limit the number of log lines buffered in the UI view #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlCutter
force-pushed
the
who_ate_all_the_memory
branch
from
4b822af to
a40e8ed
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #152 +/- ##
===========================================
- Coverage 55.99% 28.24% -27.75%
===========================================
Files 8 15 +7
Lines 759 1455 +696
===========================================
- Hits 425 411 -14
- Misses 265 965 +700
- Partials 69 79 +10 ☔ View full report in Codecov by Sentry. |
mhutchinson
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR puts a (currently) hard-coded limit on the number of log lines the UI buffers.
This avoids very long-running instances of the hammer from gobbling up all the RAM.