Generated leaves start at the size of the tree #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this change the generated leaves always start at size 0, which means many writes are squashable as duplicates on the second run of the tool. With this change, generated leaves will be unique except where the intended duplicate generation code kicks in.
|
There are a couple of small unrelated improvements in here that I've just included to be pragmatic, but I can put them in a separate PR if desired. |
AlCutter
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change the generated leaves always start at size 0, which
means many writes are squashable as duplicates on the second run of the
tool. With this change, generated leaves will be unique except where the
intended duplicate generation code kicks in.