Refactor the readers to have a single reader class #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The strategy for choosing the next leaf to read is now dictated by a function. This allows much of the logic to be simplified and the getLeaf function can now become an method of the reader, which avoids needing to pass in as many parameters.
AlCutter
reviewed
Apr 23, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #121 +/- ##
==========================================
+ Coverage 55.99% 60.26% +4.26%
==========================================
Files 8 8
Lines 759 609 -150
==========================================
- Hits 425 367 -58
+ Misses 265 173 -92
Partials 69 69 ☔ View full report in Codecov by Sentry. |
AlCutter
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The strategy for choosing the next leaf to read is now dictated by a
function. This allows much of the logic to be simplified and the getLeaf
function can now become an method of the reader, which avoids needing to
pass in as many parameters.