Add text-based UI for hammer #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This required some refactoring to create an object tree to keep references to all of the components that had previously been let loose in their own goroutines without any references. This provides a key handler for increasing/decreasing ops/s (using +/-).
AlCutter
approved these changes
Apr 18, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #114 +/- ##
==========================================
+ Coverage 55.99% 60.26% +4.26%
==========================================
Files 8 8
Lines 759 609 -150
==========================================
- Hits 425 367 -58
+ Misses 265 173 -92
Partials 69 69 ☔ View full report in Codecov by Sentry. |
It's not thread-safe, but it's probably good enough. Adding a mutex starts to make this a lot more complicated for an initialization process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This required some refactoring to create an object tree to keep references to all of the components that had previously been let loose in their own goroutines without any references.
This provides a key handler for increasing/decreasing ops/s (using +/-).