Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop TLS dep entirely #150

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Drop TLS dep entirely #150

merged 2 commits into from
Sep 18, 2024

Conversation

AlCutter
Copy link
Collaborator

This PR removes the dependency on the 3rd party TLS encoding lib.

TLS encoding is only used to serialise the STH preimage for verifying its signature, this is actually a pretty simple case since all the components are fixed sizes - there's no need for the extra complexity which comes from a fully featured TLS encoder, so we can just implement it inline.

@AlCutter AlCutter requested a review from a team as a code owner September 17, 2024 16:24
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.24%. Comparing base (fa00c16) to head (fa5b285).
Report is 65 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #150      +/-   ##
==========================================
- Coverage   82.57%   77.24%   -5.33%     
==========================================
  Files           5        6       +1     
  Lines         241      334      +93     
==========================================
+ Hits          199      258      +59     
- Misses         30       45      +15     
- Partials       12       31      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mhutchinson mhutchinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@AlCutter AlCutter merged commit d305a13 into transparency-dev:main Sep 18, 2024
8 checks passed
@AlCutter AlCutter deleted the mini_tls branch September 18, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants