-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop dep on the certificate-transparency-go repo #125
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #125 +/- ##
==========================================
- Coverage 82.57% 76.47% -6.11%
==========================================
Files 5 6 +1
Lines 241 323 +82
==========================================
+ Hits 199 247 +48
- Misses 30 45 +15
- Partials 12 31 +19 ☔ View full report in Codecov by Sentry. |
@mhutchinson need a re-approval as I had to rebase and resolve |
note/note_rfc6962.go
Outdated
@@ -29,7 +29,8 @@ import ( | |||
"strings" | |||
"time" | |||
|
|||
ct "github.com/google/certificate-transparency-go" | |||
//"github.com/google/certificate-transparency-go/tls" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this comment serving any value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gah, will need another re-approve.
This PR removes the temporary dep on the certificate-transparency-go repo by implementing serialisation of STH signature preimages locally.
Fises #105