Add RPCs to fetch crash and console logs #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phbnf
reviewed
Mar 26, 2024
| return errors.New("nil buffer passed") | ||
| } | ||
|
|
||
| *ret = getConsoleLogs() |
There was a problem hiding this comment.
This will only return something in debug mode, as opposed as the other function. Maybe this is something you want to mention here or not? Not blocking for this PR!
There was a problem hiding this comment.
Yup - that's expected, thanks for calling out though!
phbnf
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides RPCs which the applet can use to fetch the console (OS+applet) and crash (OS+applet from the last time the applet unexpectedly exited) logs. E.g. to make them available to the custodian via HTTP.