Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clearer logging in self-update #28

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

mhutchinson
Copy link
Contributor

The old logging appeared as:

I0307 15:41:31.709551       3 update.go:100] Installed (os: 0.3.1709825047-incompatible applet: 0.3.1709823315-incompatible)
I0307 15:41:31.721181       3 update.go:101] Updates (os: 0.3.1709825047-incompatible applet: 0.3.1709823315-incompatible)

This takes up two lines on a regular schedule, and looks like it is performing an operation.
This logging has now been moved to only when no updates are applied and takes a single line.

When an update is being applied, we still get an entry that says Upgrading OS/applet from X to Y.

The old logging appeared as:

```
I0307 15:41:31.709551       3 update.go:100] Installed (os: 0.3.1709825047-incompatible applet: 0.3.1709823315-incompatible)
I0307 15:41:31.721181       3 update.go:101] Updates (os: 0.3.1709825047-incompatible applet: 0.3.1709823315-incompatible)
```

This takes up two lines on a regular schedule, and looks like it is performing an operation.
This logging has now been moved to only when no updates are applied and takes a single line.

When an update is being applied, we still get an entry that says `Upgrading OS/applet from X to Y`.
@mhutchinson mhutchinson merged commit 95b64a0 into transparency-dev:main Mar 11, 2024
6 checks passed
@mhutchinson mhutchinson deleted the klogUpdates branch March 11, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants