Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't serialise empty sub structs in manifest #25

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Don't serialise empty sub structs in manifest #25

merged 2 commits into from
Feb 13, 2024

Conversation

AlCutter
Copy link
Contributor

@AlCutter AlCutter commented Feb 13, 2024 •
edited
Loading

This PR makes empty sub-structs (e.g. HAB or BuildEnvs) in the manifest be omitted during serialisation.

For HAB, it's necessary to change the field in the manifest to be *HAB for the omit to work there.

@AlCutter AlCutter requested a review from mhutchinson February 13, 2024 10:29
@AlCutter AlCutter merged commit b71051a into transparency-dev:main Feb 13, 2024
6 checks passed
@AlCutter AlCutter deleted the omitempty branch February 13, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhutchinson mhutchinson mhutchinson approved these changes

Assignees

@mhutchinson mhutchinson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlCutter @mhutchinson