Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firmware binary path is CAS-like #15

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

AlCutter
Copy link
Contributor

@AlCutter AlCutter commented Oct 31, 2023

This PR redefines the path to a firmware to be a lower-case hex string of the binary's SHA256 hash.

Having the binaries in a CAS (as opposed to in a directory structure containing release versions, type, etc.) has a few benefits in our scenario:

  • it provides a forcing function for binaries to always be accessed via the FT log (since the binary in the manifest is referenced only by its hash). This serves as a good reference example and helps folks do the right thing.
  • it avoids any risk of binaries being accidentally overwritten due to accidental moving of git tags between commits, or by external inputs (e.g. env vars) which alter the binary not being captured in the path.

@AlCutter AlCutter changed the title Firmware bins from CAS Firmware binary path is CAS-like Oct 31, 2023
Copy link

@jiggoha jiggoha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also add a short summary for the motivation to do this in the PR description?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants