Derive attestation key and use it to attest to generated witness ID #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Happy with the key name, or should it just be |
mhutchinson
approved these changes
Mar 7, 2024
| status.Serial, | ||
| status.HAB, | ||
| func(rnd io.Reader) string { | ||
| return fmt.Sprintf("%sArmoredWitness-%s", prefix, randomName(rnd)) | ||
| }) | ||
|
|
||
| attestPublicKey, witnessPublicKeyAttestation = attestID(&status, witnessPublicKey) |
There was a problem hiding this comment.
Should the function name be changed from deriveWitnessKey to deriveKeys ?
There was a problem hiding this comment.
yeah, seems reasonable - I've gone with deriveIdentityKeys to be clearer still.
Key name is fine with me. I don't think we need to be terse. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds applet support for deriving a stable ID attestation key, and using it to create a simple attestation for witness IDs.
Note that this is a breaking change for witness identities, since we've modified the Witness ID diversifer string.
Example attestation: