SwiftUI support #66
Merged
SwiftUI support #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds attributed string swizzling that allows Transifex SDK to allow for SwiftUI support. * De-swizzles methods when SDK is deactivated (when `dispose` is called). * Adds public static method to deactivate swizzling on passed `Bundle` instance. * Ensures that the special Transifex `.stringsdict` key used to calculate the plural rules, cannot be swizzled (`TRANSIFEX_STRINGSDICT_KEY`). * Ensures that SDK is properly deactivated when a unit test finishes, so that swizzling is re-applied correctly on each test. * Adds unit test for the `localizedAttributedString:...` method in Objective-C. * Adds unit test for the `NSLocalizedString()` method in Swift. NOTE: SwiftUI elements (`View`, `Button` etc) cannot be added to unit tests.
* Bumps `TXNative.version` to 2.0.3. * Updates CHANGELOG with the changes implemented for 2.0.3.
stelabouras
force-pushed
the
feature/swiftui
branch
from
8108bb9
to
f0facf6
Compare
n1k0sv
approved these changes
Jun 10, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SwiftUI support
for SwiftUI support.
disposeiscalled).
Bundleinstance.
.stringsdictkey used tocalculate the plural rules, cannot be swizzled
(
TRANSIFEX_STRINGSDICT_KEY).that swizzling is re-applied correctly on each test.
localizedAttributedString:...method inObjective-C.
NSLocalizedString()method in Swift.NOTE: SwiftUI elements (
View,Buttonetc) cannot be added to unittests.
Bump version to 2.0.3
TXNative.versionto 2.0.3.