Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setup section parse in vue 3 files #202

Closed
wants to merge 1 commit into from

Conversation

Vldln
Copy link

@Vldln Vldln commented Dec 12, 2023

Parser doesn't identify vue3 setup script section. Add condition section which check exist of vueContent.descriptor.scriptSetup and parse content.

@n1k0sv
Copy link

n1k0sv commented Jan 3, 2024

@Vldln Thank you for your contribution. We really appreciate it.

Would it be possible to do the following before we can merge this PR?

  1. Add a script setup sample in test/fixtures/vuejs.vue and update the related vue test in the CLI, testing the case you fixed.
  2. Run npm run lint in the packages/cli folder to fix some linting errors.
  3. Sign the CLA as explained in the CONTRIBUTING.md . (This is only required once)

@n1k0sv
Copy link

n1k0sv commented Jan 11, 2024

Closing this in favor of #208

@n1k0sv n1k0sv closed this Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants