Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add location config to bigquery fastsync #741

Merged
merged 2 commits into from
Jul 15, 2021

Conversation

jmriego
Copy link
Contributor

@jmriego jmriego commented Jul 14, 2021

Problem

BigQuery in fastsync mode is ignoring the location project config and writing to the default location

Proposed changes

Change the open connection function call to use the location added in the target yml file

Types of changes

What types of changes does your code introduce to PipelineWise?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Description above provides context of the change
  • I have added tests that prove my fix is effective or that my feature works
  • Unit tests for changes (not needed for documentation changes)
  • CI checks pass with my changes
  • Bumping version in setup.py is an individual PR and not mixed with feature or bugfix PRs
  • Commit message/PR title starts with [AP-NNNN] (if applicable. AP-NNNN = JIRA ID)
  • Branch name starts with AP-NNN (if applicable. AP-NNN = JIRA ID)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions

@jmriego jmriego changed the title add location config to bigquery fastsync WIP: add location config to bigquery fastsync Jul 14, 2021
@jmriego
Copy link
Contributor Author

jmriego commented Jul 14, 2021

@AlexStansfield this fixes #739
I'm still working on the unit tests but sending the MR as a WIP now in case this helps you

@AlexStansfield
Copy link

@jmriego thanks so much. Really appreciate you working on it so quickly

@jmriego
Copy link
Contributor Author

jmriego commented Jul 14, 2021

sure thing! we use PipelineWise daily at work so happy to help :)

@jmriego jmriego changed the title WIP: add location config to bigquery fastsync add location config to bigquery fastsync Jul 14, 2021
@koszti koszti merged commit d6c80f1 into transferwise:master Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants