This repository has been archived by the owner on Jan 31, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 19
KaTeX support #174
Open
MoshiBar
wants to merge
1
commit into
transfem-org:develop
Choose a base branch
from
MoshiBar:katex
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
KaTeX support #174
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
<template> | ||
<XFormula :formula="formula" :block="block" /> | ||
</template> | ||
|
||
<script lang="ts"> | ||
import { defineAsyncComponent, defineComponent } from "vue"; | ||
|
||
export default defineComponent({ | ||
components: { | ||
XFormula: defineAsyncComponent( | ||
() => import("@/components/MkFormulaCore.vue"), | ||
), | ||
}, | ||
props: { | ||
formula: { | ||
type: String, | ||
required: true, | ||
}, | ||
block: { | ||
type: Boolean, | ||
required: true, | ||
}, | ||
}, | ||
}); | ||
</script> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
<template> | ||
<div v-if="block" v-html="compiledFormula"></div> | ||
<span v-else v-html="compiledFormula"></span> | ||
</template> | ||
|
||
<script lang="ts"> | ||
import { defineComponent } from "vue"; | ||
import katex from "katex"; | ||
|
||
export default defineComponent({ | ||
props: { | ||
formula: { | ||
type: String, | ||
required: true, | ||
}, | ||
block: { | ||
type: Boolean, | ||
required: true, | ||
}, | ||
}, | ||
computed: { | ||
compiledFormula(): any { | ||
const katexString = katex.renderToString(this.formula, { | ||
throwOnError: false, | ||
} as any); | ||
return this.block | ||
? `<div style="text-align:center">${katexString}</div>` | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Some kind of simple HTML sanitization could be made here, depending on what KaTeX renders to you might be able to just drop all non-math HTML tags and their attributes |
||
: katexString; | ||
}, | ||
}, | ||
}); | ||
</script> | ||
|
||
<style> | ||
@import "../../node_modules/katex/dist/katex.min.css"; | ||
</style> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i feel like this would be better as part of the vue template instead of being inline html, with text-align:center applied via <style> instead of being inline