B-21569 Main #14683
Merged
B-21569 Main #14683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-Service-Items' into B-21569
only include Fuel Surcharge FSC if either origin or destination is CONUS.
…to_shipment_updater, moved the tests over and updated for POEFSC and PODFSC instead of just FSC.
Instead of inserting them as we encounter them in the proc, collect them into a temp table, sort them, and then insert.
from just "International UB".
Include the sort field in listMTOServiceItems operation. Update the sorting logic in ServiceItemsTable.jsx. Remove my changes to the stored procedure. Move testing from shipment_approver to the service and UI tests.
added test and ensure nulls are sorted After those with sort values.
Add logic in model_to_payload to match on ShipmentType and MarketCode. Update test to use matching shipment info.
additional test in model_to_payload_test, no need to compare to blank strings because those are non-null DB enums, fix the multiple joins on the MTOServiceItem query, remove the unneeded UUID generation in mto_service_items_test.
stevengleason-caci
requested review from
danieljordan-caci and
brianmanley-caci
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded
Removed
Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
brianmanley-caci
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
B-21569
B-21569
Summary
Add service items for Unaccompanied Baggage.
The feature mentions that the Fuel Surcharge is only for when either the Origin or Destination is CONUS.
I updated the preview page also.
Fix the order of the service items. I did this by retrieving the sort column and using that in the jsx code.
I also changed "International UB" to "International UB price."
INT PR 1: #14491
INT PR 2: #14577
Verification Steps for the Author
These are to be checked by the author.
Verification Steps for Reviewers
These are to be checked by a reviewer.
Setup to Run the Code
How to test
a. International UB price
b. International POE Fuel Surcharge
c. International UB pack
d. International UB unpack
a. International UB price
b. International UB pack
c. International UB unpack
a. International UB price
b. International POD Fuel Surcharge
c. International UB pack
d. International UB unpack
Frontend
officeAppclass or custommin-widthstyling is used to hide any states the would not be visible to the user.Backend
Database
Any new migrations/schema changes:
Screenshots
CONUS-OCONUS with POE FSC
OCONUS-OCONUS (no FSC)
OCONUS-CONUS with POD FSC