B 21977 INT Part 2 - Fix Office User Select Counseling Office Validation

[ajlusk]

B-21977

INT PR Part 1

Summary

Fixes some validation issues found during PO acceptance.

Also applies consistent "Required" hints to the orders form in the office ap per reviewer suggestion.

Verification Steps for the Author

These are to be checked by the author.

• Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
• Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers

These are to be checked by a reviewer.

• Has the branch been pulled in and checked out?
• Have the BL acceptance criteria been met for this change?
• Was the CircleCI build successful?
• Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

• Instructions for starting storybook
• Instructions for starting the MilMove application
• Instructions for running tests

How to test (New steps in bold)

1. Access the office app
2. Login as a services counselor
3. Navigate to the customer search page
4. Search for any customer, maybe Spacemen, Leo
5. Create a new move for you selected user
6. On the orders form, are all required fields marked as such?
7. When creating orders for your new move ensure the counseling office dropdown appears after selecting a current duty location that provides government counseling.
8. Ensure the "Next" button remains disabled until all required fields are populated, specifically when all fields populated except the counseling office.
9. Add any shipment to your newly created move so it will show up on your queue
10. Navigate to your counseling queue, find the move you just created, and ensure the list counseling office matches the office you selected in step 7.

Frontend

• There are no aXe warnings for UI.
• This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
• There are no new console errors in the browser devtools.
• There are no new console errors in the test output.
• If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
• This change meets the standards for Section 508 compliance.

Backend

• Code follows the guidelines for Logging.
• The requirements listed in Querying the Database Safely have been satisfied.

Database

Any new migrations/schema changes:

• Follows our guidelines for Zero-Downtime Deploys.
• Have been communicated to #g-database.
• Secure migrations have been tested following the instructions in our docs.

Screenshots

[antgmann]

Above comment resolved! Works great, thanks for the change
Edit: Removing approval because of client test issues

[ajlusk]

Draft again for failing tests that are in integration but not main