-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
B 21544 prime successful update message int #14588
B 21544 prime successful update message int #14588
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👽
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works good. Looks good.
Couldn't hurt to add a test to help keep the coverage up.
src/pages/MyMove/Agreement.test.jsx:~65 (among others) seems to have a good example to testing the flash message. Lmk if you add one, I'll re-approve quickly.
Ah yea thats a good point! I'll work adding that test in |
c340cf3
…544-Prime-Successful-Update-Message-INT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding a test. Sorry it turned out to be a pain.
It's better to keep up with the test coverage than not. And I definitely need to work on my FE tests so no worries! |
Those failing client tests say flaky but I think it might instead be a wonky merge. I was in that file recently and those |
B-21544
Summary
This PR allows for a success message to flash when the prime updates a shipment's destination address.
Verification Steps for Reviewers
These are to be checked by a reviewer.
How to test
Frontend
officeApp
class or custommin-width
styling is used to hide any states the would not be visible to the user.Screenshots