Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B 21544 prime successful update message int #14588

Merged

Conversation

KonstanceH
Copy link
Contributor

@KonstanceH KonstanceH commented Jan 15, 2025

B-21544

Summary

This PR allows for a success message to flash when the prime updates a shipment's destination address.

Verification Steps for Reviewers

These are to be checked by a reviewer.

  • Has the branch been pulled in and checked out?
  • Have the BL acceptance criteria been met for this change?
  • Was the CircleCI build successful?
  • Has the code been reviewed from a standards and best practices point of view?

How to test

  1. Login as the Prime
  2. Find a move that you can change the delivery address on. For example an HHG move.
  3. Click "Update shipment Delivery Address"
  4. Update the address and save
  5. Confirm seeing the Success message

Frontend

  • There are no aXe warnings for UI.
  • This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
  • There are no new console errors in the browser devtools.
  • There are no new console errors in the test output.
  • If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
  • This change meets the standards for Section 508 compliance.

Screenshots

Screenshot 2025-01-15 at 1 55 27 PM

@KonstanceH KonstanceH self-assigned this Jan 15, 2025
@KonstanceH KonstanceH added ByteSize M&Ms Team ByteSized M&Ms INTEGRATION Slated for Integration Testing labels Jan 15, 2025
@KonstanceH KonstanceH marked this pull request as ready for review January 15, 2025 20:02
@KonstanceH KonstanceH requested review from a team as code owners January 15, 2025 20:02
taeJungCaci
taeJungCaci previously approved these changes Jan 15, 2025
Copy link
Contributor

@taeJungCaci taeJungCaci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@WeatherfordAaron WeatherfordAaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👽

ajlusk
ajlusk previously approved these changes Jan 16, 2025
Copy link
Contributor

@ajlusk ajlusk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works good. Looks good.

Couldn't hurt to add a test to help keep the coverage up.
src/pages/MyMove/Agreement.test.jsx:~65 (among others) seems to have a good example to testing the flash message. Lmk if you add one, I'll re-approve quickly.

@KonstanceH
Copy link
Contributor Author

Works good. Looks good.

Couldn't hurt to add a test to help keep the coverage up. src/pages/MyMove/Agreement.test.jsx:~65 (among others) seems to have a good example to testing the flash message. Lmk if you add one, I'll re-approve quickly.

Ah yea thats a good point! I'll work adding that test in

ajlusk
ajlusk previously approved these changes Jan 23, 2025
Copy link
Contributor

@ajlusk ajlusk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding a test. Sorry it turned out to be a pain.

@KonstanceH
Copy link
Contributor Author

Thanks for adding a test. Sorry it turned out to be a pain.

It's better to keep up with the test coverage than not. And I definitely need to work on my FE tests so no worries!

@ajlusk
Copy link
Contributor

ajlusk commented Jan 23, 2025

Those failing client tests say flaky but I think it might instead be a wonky merge. I was in that file recently and those 'Orders type' lines it's failing on need to be /Orders type/ like they are in integrationTesting, but not yet in main.

@KonstanceH KonstanceH merged commit c67c0d0 into integrationTesting Jan 23, 2025
35 checks passed
@KonstanceH KonstanceH deleted the B-21544-Prime-Successful-Update-Message-INT branch January 23, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ByteSize M&Ms Team ByteSized M&Ms INTEGRATION Slated for Integration Testing
Development

Successfully merging this pull request may close these issues.

4 participants