Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B 21474 int calculate mileage using dtod for ak oconus shipments #14550

Conversation

joeydoyecaci
Copy link
Contributor

@joeydoyecaci joeydoyecaci commented Jan 9, 2025

B-21474

Summary

Adds the ability to use DTOD to calculate mileage if either destination or pickup addresses are OCONUS to support calculation of RDD

###Setup
A breakpoint is required for the following lines
pkg/services/mto_shipment/mto_shipment_updater.go:1206
pkg/services/mto_shipment/mto_shipment_updater.go:1208

How to test

[important] Debugger must be enabled as RDD is not currently displayed

  1. Create a new customer with a new HHG shipment. One of the addresses in the shipment should be Alaska
  2. Submit shipment as SC like normal, approve the shipment as TOO
  3. Update the shipment as a Prime user with all required fields, including a weight.
  4. In calculate CalculateRequiredDeliveryDate use a breakpoint to verify thatplanner.ZipTransitDistance is run with internationalShipment set to true.
  5. step through planner.ZipTransitDistance and verify that DTOD is called to calculate the mileage
  6. verify that a nonzero mileage is being returned for planner.ZipTransitDistance

@joeydoyecaci joeydoyecaci self-assigned this Jan 9, 2025
@joeydoyecaci joeydoyecaci added the INTEGRATION Slated for Integration Testing label Jan 9, 2025
@joeydoyecaci joeydoyecaci added the G-Unit Scrum Team G label Jan 15, 2025
@joeydoyecaci joeydoyecaci marked this pull request as ready for review January 15, 2025 20:33
@joeydoyecaci joeydoyecaci requested review from a team as code owners January 15, 2025 20:33
begrohmann
begrohmann previously approved these changes Jan 15, 2025
Copy link
Contributor

@loganwc loganwc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got 3708 mi between my house and Elmendorf, looks good to me

Google maps doesn't use the same data so there's not really a good way to confirm
Screenshot 2025-01-21 at 4 04 25 PM

@pambecker
Copy link
Contributor

If this doesn't show on the UI, how will Mai test this and POA go for this story?

@joeydoyecaci
Copy link
Contributor Author

joeydoyecaci commented Jan 22, 2025

If this doesn't show on the UI, how will Mai test this and POA go for this story?

In this case I'll need to demo the change at POA to show that DTOD is being called on a OCONUS shipment instead of RandMcNally. While the RDD can be seen on an HHG shipment after it is updated by Prime, I don't think it would provide the best visibility on this change.

@pambecker
Copy link
Contributor

If this doesn't show on the UI, how will Mai test this and POA go for this story?

In this case I'll need to demo the change at POA to show that DTOD is being called on a OCONUS shipment instead of RandMcNally. While the RDD can be seen on an HHG shipment after it is updated by Prime, I don't think it would provide the best visibility on this change.

Ok, let's bring this up in team sync, just to get eyes on this early and to bring awareness.

Copy link
Contributor

@danieljordan-caci danieljordan-caci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

most excellent! I agree that the useDTOD became redundant with the addition of the isInternationalShipment bool. LGTM!

@joeydoyecaci joeydoyecaci merged commit 280748e into integrationTesting Jan 23, 2025
31 of 33 checks passed
@joeydoyecaci joeydoyecaci deleted the B-21474-INT-Calculate-Mileage-Using-DTOD-For-AK-OCONUS-Shipments branch January 23, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
G-Unit Scrum Team G INTEGRATION Slated for Integration Testing
Development

Successfully merging this pull request may close these issues.

5 participants