-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
B 21474 int calculate mileage using dtod for ak oconus shipments #14550
B 21474 int calculate mileage using dtod for ak oconus shipments #14550
Conversation
…-Shipments' into B-21474-INT-Calculate-Mileage-Using-DTOD-For-AK-OCONUS-Shipments
…Using-DTOD-For-AK-OCONUS-Shipments
…r-AK-OCONUS-Shipments
…Using-DTOD-For-AK-OCONUS-Shipments
…r-AK-OCONUS-Shipments
…-Shipments' into B-21474-INT-Calculate-Mileage-Using-DTOD-For-AK-OCONUS-Shipments
…Using-DTOD-For-AK-OCONUS-Shipments
…Using-DTOD-For-AK-OCONUS-Shipments
…r-AK-OCONUS-Shipments
…Using-DTOD-For-AK-OCONUS-Shipments
…Using-DTOD-For-AK-OCONUS-Shipments
…Using-DTOD-For-AK-OCONUS-Shipments
…-Shipments' into B-21474-INT-Calculate-Mileage-Using-DTOD-For-AK-OCONUS-Shipments
…Using-DTOD-For-AK-OCONUS-Shipments
…-Shipments' into B-21474-INT-Calculate-Mileage-Using-DTOD-For-AK-OCONUS-Shipments
…r-AK-OCONUS-Shipments
…Using-DTOD-For-AK-OCONUS-Shipments
…-Shipments' into B-21474-INT-Calculate-Mileage-Using-DTOD-For-AK-OCONUS-Shipments
…Using-DTOD-For-AK-OCONUS-Shipments
…Using-DTOD-For-AK-OCONUS-Shipments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this doesn't show on the UI, how will Mai test this and POA go for this story? |
In this case I'll need to demo the change at POA to show that DTOD is being called on a OCONUS shipment instead of RandMcNally. While the RDD can be seen on an HHG shipment after it is updated by Prime, I don't think it would provide the best visibility on this change. |
…Using-DTOD-For-AK-OCONUS-Shipments
Ok, let's bring this up in team sync, just to get eyes on this early and to bring awareness. |
…Using-DTOD-For-AK-OCONUS-Shipments
…Using-DTOD-For-AK-OCONUS-Shipments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
most excellent! I agree that the useDTOD
became redundant with the addition of the isInternationalShipment
bool. LGTM!
…Using-DTOD-For-AK-OCONUS-Shipments
B-21474
Summary
Adds the ability to use DTOD to calculate mileage if either destination or pickup addresses are OCONUS to support calculation of RDD
###Setup
A breakpoint is required for the following lines
pkg/services/mto_shipment/mto_shipment_updater.go:1206
pkg/services/mto_shipment/mto_shipment_updater.go:1208
How to test
[important] Debugger must be enabled as RDD is not currently displayed
CalculateRequiredDeliveryDate
use a breakpoint to verify thatplanner.ZipTransitDistance
is run withinternationalShipment
set to true.planner.ZipTransitDistance
and verify that DTOD is called to calculate the mileageplanner.ZipTransitDistance