INT B-22140 #14489

begrohmann · 2024-12-30T19:22:05Z

B-22140

Summary

Adding Camp Pendleton, CA as a Counseling Office for LKNQ associated with Camp Pendleton duty location. This is CM'ing a defect fixed in Prod under INC1896099.

Is there anything you would like reviewers to give additional scrutiny?

this article explains more about the approach used.

Verification Steps for the Author

These are to be checked by the author.

Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers

When origin duty location is Camp Pendleton, CA, the user should see PPPO DMO Camp Pendleton in the Counseling Office drop down list.

These are to be checked by a reviewer.

Has the branch been pulled in and checked out?
Have the BL acceptance criteria been met for this change?
Was the CircleCI build successful?
Has the code been reviewed from a standards and best practices point of view?

How to test

Login as a Service Member
Create new orders
Select Camp Pendleton, CA as origin duty location
Select the Counseling Office drop down and ensure PPPO DMO Camp Pendleton is in the list and can be selected

Frontend

There are no aXe warnings for UI.
This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
There are no new console errors in the browser devtools.
There are no new console errors in the test output.
If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
This change meets the standards for Section 508 compliance.

Backend

Code follows the guidelines for Logging.
The requirements listed in Querying the Database Safely have been satisfied.

Database

Any new migrations/schema changes:

Follows our guidelines for Zero-Downtime Deploys.
Have been communicated to #g-database.
Secure migrations have been tested following the instructions in our docs.

Screenshots

MAIN B-22139

MAIN-B-21505

….sql

…2140

ryan-mchugh · 2025-01-02T17:52:59Z

migrations/app/schema/20241227202424_insert_transportation_offices_camp_pendelton.up.sql

+update addresses set postal_code = '92054', us_post_region_cities_id = 'd0c818dc-1e6c-416a-bfa9-2762efebaed1' where id = 'af2ebb73-54fe-46e0-9525-a4568ceb9e0e';
+
+--fix Camp Pendelton transportation office spelling
+update transportation_offices set name = 'PPPO DMO Camp Pendelton' where id = 'f50eb7f5-960a-46e8-aa64-6025b44132ab';


I believe the spelling should be Pendleton instead here.

@begrohmann what did you do?? did you misspell it on purpose?

ryan-mchugh · 2025-01-02T17:53:59Z

playwright/tests/my/mymove/orders.spec.js

@@ -110,7 +110,7 @@ test.describe('(MultiMove) Orders', () => {
    await page.getByRole('combobox', { name: 'Pay grade' }).selectOption({ label: 'E-7' });
    await page
      .getByRole('combobox', { name: 'Counseling Office' })
-      .selectOption({ label: 'PPPO DMO Camp Pendleton - USMC' });
+      .selectOption({ label: 'PPPO DMO Camp Pendelton - USMC' });


Are we sure we need to change this to Pendelton? Maybe an intentional Misspelling?

ryan-mchugh · 2025-01-02T17:55:08Z

Origin duty location has spelling as Pendleton - google agrees

deandreJones · 2025-01-02T18:13:38Z

Origin duty location has spelling as Pendleton - google agrees

yep I just googled the base... definitely spelled Pendleton. @begrohmann
good catch Ryan

ryan-mchugh · 2025-01-02T20:19:09Z

migrations/app/schema/20241227202424_insert_transportation_offices_camp_pendelton.up.sql

+--update address for Camp Pendelton transportation office
+update addresses set postal_code = '92054', us_post_region_cities_id = 'd0c818dc-1e6c-416a-bfa9-2762efebaed1' where id = 'af2ebb73-54fe-46e0-9525-a4568ceb9e0e';
+
+--fix Camp Pendelton transportation office spelling


(minor) misspelling still there on comments and migration name
Approving

ryan-mchugh

updates look good

brianmanley-caci and others added 11 commits December 23, 2024 14:23

Merge remote-tracking branch 'origin/main' into MAIN-B-21505

40251b2

Merge branch 'main' into MAIN-B-21505

8da9bed

Merge branch 'main' into MAIN-B-21505

f88c10c

Merge branch 'main' into MAIN-B-21505

e3543b6

Add Camp Pendelton transportation office

c5456eb

Merge pull request #14476 from transcom/MAIN-B-22139

c6ae1bf

MAIN B-22139

Merge branch 'main' into MAIN-B-21505

8624ada

Merge pull request #14459 from transcom/MAIN-B-21505

6fb9a16

MAIN-B-21505

Update 20241227202424_insert_transportation_offices_camp_pendelton.up…

faa4cde

….sql

Merge branch 'B-22140' into INT-B-22140

7f50eb1

Merge remote-tracking branch 'origin/integrationTesting' into INT-B-2…

2fb42d2

…2140

begrohmann requested a review from a team as a code owner December 30, 2024 19:22

begrohmann requested a review from danieljordan-caci December 30, 2024 19:22

begrohmann assigned begrohmann and deandreJones and unassigned begrohmann Dec 30, 2024

begrohmann requested review from cameroncaci, CoryKleinjanCACI and brianmanley-caci December 30, 2024 19:23

Merge branch 'integrationTesting' into INT-B-22140

9483802

deandreJones requested review from a team, deandreJones, TevinAdams and traskowskycaci January 2, 2025 14:03

spelling matters

fc61b20

deandreJones requested a review from a team as a code owner January 2, 2025 17:14

danieljordan-caci previously approved these changes Jan 2, 2025

View reviewed changes

ryan-mchugh reviewed Jan 2, 2025

View reviewed changes

deandreJones added 2 commits January 2, 2025 18:05

fix playwright

caa4907

i blame beth

d64def6

deandreJones dismissed danieljordan-caci’s stale review via d64def6 January 2, 2025 18:08

deandreJones added Mountain Movers Movin' Mountains 1 Sprint at a time INTEGRATION Slated for Integration Testing labels Jan 2, 2025

ryan-mchugh reviewed Jan 2, 2025

View reviewed changes

ryan-mchugh approved these changes Jan 2, 2025

View reviewed changes

deandreJones merged commit 0fecb61 into integrationTesting Jan 3, 2025
34 checks passed

deandreJones deleted the INT-B-22140 branch January 3, 2025 17:36

deandreJones mentioned this pull request Jan 6, 2025

B 22140 #14520

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

INT B-22140 #14489

INT B-22140 #14489

begrohmann commented Dec 30, 2024 •

edited by deandreJones

Loading

ryan-mchugh Jan 2, 2025

deandreJones Jan 2, 2025

ryan-mchugh Jan 2, 2025

deandreJones Jan 2, 2025

ryan-mchugh commented Jan 2, 2025

deandreJones commented Jan 2, 2025 •

edited

Loading

ryan-mchugh Jan 2, 2025

ryan-mchugh left a comment

INT B-22140 #14489

INT B-22140 #14489

Conversation

begrohmann commented Dec 30, 2024 • edited by deandreJones Loading

Summary

Verification Steps for the Author

Verification Steps for Reviewers

How to test

Frontend

Backend

Database

Any new migrations/schema changes:

Screenshots

ryan-mchugh Jan 2, 2025

Choose a reason for hiding this comment

deandreJones Jan 2, 2025

Choose a reason for hiding this comment

ryan-mchugh Jan 2, 2025

Choose a reason for hiding this comment

deandreJones Jan 2, 2025

Choose a reason for hiding this comment

ryan-mchugh commented Jan 2, 2025

deandreJones commented Jan 2, 2025 • edited Loading

ryan-mchugh Jan 2, 2025

Choose a reason for hiding this comment

ryan-mchugh left a comment

Choose a reason for hiding this comment

begrohmann commented Dec 30, 2024 •

edited by deandreJones

Loading

deandreJones commented Jan 2, 2025 •

edited

Loading