Int b 21507 pod poe too validation #14475

msaki-caci · 2024-12-26T22:04:39Z

B-21507

Summary

We are adding a view for the Port of Embark and Port of Debark for the TOO and any other office user with the ability to view the MTO page.

They should be able to view the Port of Embark or Port of Debark based on whichever one is populated the other port should be blank. Here is an example:

Verification Steps for the Author

These are to be checked by the author.

Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers

These are to be checked by a reviewer.

Has the branch been pulled in and checked out?
Have the BL acceptance criteria been met for this change?
Was the CircleCI build successful?
Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

How to test

NOTE: We are following the same steps for 1-5 from B-21505 to setup the location for the POE/POD.

Create an INTL UB shipment as a customer (CONUS -> AK or AK -> CONUS)
Manually create the mto_service_items table for the shipment: INSERT INTO mto_service_items ( id, mto_shipment_id, move_id, re_service_id, status, created_at, updated_at, approved_at ) VALUES ( uuid_generate_v4(), '8eeba537-bb40-4f58-a534-74ea9ff64590', '813b7a43-2e3f-42f3-8c4e-eca95390d5ca', '388115e8-abe9-441d-96cf-a39f24baa0a3', 'APPROVED'::service_item_status, NOW(), NOW(), NOW() );
In the prime v3 api, call getMoveTaskOrder using the move_id for the service item you created in step 2. You will need the etag for the newly created service item for the next step.
In the prime v1 api, call updateMTOServiceItem using a payload like this (adjust for you specific service item ID): { "id": "40b7e71a-6b03-4413-8601-dea694253ee3", "modelType": "UpdateMTOServiceItemInternationalPortFSC", "portCode": "PDX", "reServiceCode": "PODFSC" }
Verify that you receive a 200 response like this: { "reServiceCode": "PODFSC", "eTag": "MjAyNC0xMi0wMlQxNjo0MjoxNi42NjUwNDla", "id": "40b7e71a-6b03-4413-8601-dea694253ee3", "modelType": "MTOServiceItemBasic", "moveTaskOrderID": "813b7a43-2e3f-42f3-8c4e-eca95390d5ca", "mtoShipmentID": "8eeba537-bb40-4f58-a534-74ea9ff64590", "reServiceName": "International POD Fuel Surcharge", "status": "APPROVED" }
Login as a TOO user or any office user that has permissions to access the MTO page. Search up the move id that we used to setup the POD/POE. When you travel to the MTO Page, you should now see the Port of Embark or Debark populated with the Port Code, Port Name, City, State, and Zip associated with it.

Frontend

There are no aXe warnings for UI.
This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
There are no new console errors in the browser devtools.
There are no new console errors in the test output.
If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
This change meets the standards for Section 508 compliance.

Backend

Code follows the guidelines for Logging.
The requirements listed in Querying the Database Safely have been satisfied.

Screenshots

Add descriptions for POE/POD Locations in swagger.

Update API call to pull Port info Update MTOShipment.yaml to include Port

…on-Submit-move-details-task-order-with-files

…task-order-with-files

Add POE/POD Location to MTOShipment payload Make methods to pull the port location into the payload update swagger definitions for POE/POD locations

…t-move-details-task-order-with-files Main b 21373 validation submit move details task order with files

…m/transcom/mymove into B-22107-DynamicDP3-Stg-Prd-deploy

…ploy ci/cd work

Display Port Location and data on frontend MTO page

Pull the port location back in mto_shipment_fetcher

B-21458 Main

…ploy ci/cd work

Add PortLocationShape into address.js Add Poe/pod to PropTypes

Add tests for ShipmentAddresses.jsx Add tests for shipmentDisplay.jsx

brianmanley-caci · 2024-12-27T20:50:10Z

pkg/handlers/ghcapi/internal/payloads/model_to_payload_test.go

+
+	suite.Run("Success - Maps PortLocation to Port payload", func() {
+		// Arrange
+		portID, _ := uuid.NewV4()


You could use the port_location_factory for all this data.

Yeah I am kinda playing around with that as we speak.

src/components/Office/ShipmentAddresses/ShipmentAddresses.jsx

brianmanley-caci · 2024-12-27T21:05:45Z

swagger/ghc.yaml

@@ -10830,6 +10927,8 @@ definitions:
      storageFacility:
        x-nullable: true
        $ref: '#/definitions/StorageFacility'
+      port:


Is this needed? I see podLocation and poeLocation below, so I'm trying to think what this would be.

uhhh might not be let me go back and look

Removed it here 25c6790

I think you would need to remove it from MTOShipment.yaml instead of from this generated ghc.yaml file if that makes sense.

…OD-POE_TOO_Validation

MAIN B-22139

src/utils/shipmentDisplay.jsx

brianmanley-caci · 2024-12-27T21:37:17Z

pkg/handlers/ghcapi/internal/payloads/model_to_payload.go

@@ -1523,6 +1523,8 @@ func MTOShipment(storer storage.FileStorer, mtoShipment *models.MTOShipment, sit
 		DeliveryAddressUpdate:       ShipmentAddressUpdate(mtoShipment.DeliveryAddressUpdate),
 		ShipmentLocator:             handlers.FmtStringPtr(mtoShipment.ShipmentLocator),
 		MarketCode:                  MarketCode(&mtoShipment.MarketCode),
+		PoeLocation:                 getPortLocation(mtoShipment.MTOServiceItems, "POE"),


You could add a test for these new fields.

Refactor how dashes are shown for empty POD or POE

…OD-POE_TOO_Validation

Rename Embark and Debark to Embarkation and Debarkation

Refactor test for change of POE/POD header

…OD-POE_TOO_Validation

Remove unnecessary swagger definition for Port

josiahzimmerman-caci · 2024-12-27T22:23:21Z

@msaki-caci not sure why the .gitlab-ci.yml is showing as a conflict but whatever is in main is correct.

msaki-caci · 2024-12-27T22:25:55Z

@msaki-caci not sure why the .gitlab-ci.yml is showing as a conflict but whatever is in main is correct.

Yeah I just saw that, not really sure what happened there either. I will get it resolved

msaki-caci and others added 30 commits December 10, 2024 18:23

Merge MAIN-B-21505 into MAIN-B-21507

5ecb361

Merge MAIN-B-21505 into MAIN-B-21507

60572ec

B-21507

ea054ca

Add descriptions for POE/POD Locations in swagger.

B-21507

f229337

Update API call to pull Port info Update MTOShipment.yaml to include Port

Merge branch 'main' into MAIN-B-21507

329f2d9

Merge remote-tracking branch 'origin/main' into MAIN-B-21373-Validati…

a8b9fba

…on-Submit-move-details-task-order-with-files

Merge branch 'main' into MAIN-B-21373-Validation-Submit-move-details-…

2b26f2b

…task-order-with-files

Merge branch 'main' into MAIN-B-21373-Validation-Submit-move-details-…

b436e50

…task-order-with-files

Merge branch 'main' into MAIN-B-21373-Validation-Submit-move-details-…

81417a3

…task-order-with-files

ci/cd work

b26296e

Merge branch 'main' into B-22107-DynamicDP3-Stg-Prd-deploy

9c9ce1a

Merge branch 'main' into MAIN-B-21373-Validation-Submit-move-details-…

2f64230

…task-order-with-files

Merge branch 'main' into B-22107-DynamicDP3-Stg-Prd-deploy

d0c019b

B-21507

deeb1d5

Add POE/POD Location to MTOShipment payload Make methods to pull the port location into the payload update swagger definitions for POE/POD locations

ci/cd work

ae0ba3e

Merge branch 'main' of github.com:transcom/mymove into B-21169

917a5e9

Merge remote-tracking branch 'origin/main' into MAIN-B-21505

40251b2

Merge remote-tracking branch 'origin/B-21169' into B-21458

f2525e6

Merge pull request #14301 from transcom/MAIN-B-21373-Validation-Submi…

8897689

…t-move-details-task-order-with-files Main b 21373 validation submit move details task order with files

Merge branch 'main' into B-22107-DynamicDP3-Stg-Prd-deploy

ad12aed

ci/cd work

713d36d

Merge branch 'B-22107-DynamicDP3-Stg-Prd-deploy' of https://github.co…

403b46c

…m/transcom/mymove into B-22107-DynamicDP3-Stg-Prd-deploy

ci/cd work

aa45abf

Merge pull request #14438 from transcom/B-22107-DynamicDP3-Stg-Prd-de…

db501c5

…ploy ci/cd work

Merge branch 'main' into MAIN-B-21505

8da9bed

ci/cd work

943481a

B-21507

a416aaa

Display Port Location and data on frontend MTO page

ci/cd work

a225bc6

B-21507

14e927f

Pull the port location back in mto_shipment_fetcher

ci/cd work

e38278b

msaki-caci self-assigned this Dec 26, 2024

josiahzimmerman-caci and others added 13 commits December 26, 2024 22:06

ci/cd work

cef2807

ci/cd work

1524c8d

Merge pull request #14471 from transcom/B-21458

f266d06

B-21458 Main

Merge branch 'main' into B-22107-DynamicDP3-Stg-Prd-deploy

c533986

ci/cd work

97e63d8

ci/cd work

cbffd45

ci/cd work

161b8b7

ci/cd work

c60aeea

Merge pull request #14463 from transcom/B-22107-DynamicDP3-Stg-Prd-de…

3f539a3

…ploy ci/cd work

added backend check

21828b6

moving back inside the waitfor

4f9071a

B-21507

b778618

Add PortLocationShape into address.js Add Poe/pod to PropTypes

B-21507

ec804ce

Add tests for ShipmentAddresses.jsx Add tests for shipmentDisplay.jsx

brianmanley-caci reviewed Dec 27, 2024

View reviewed changes

msaki-caci and others added 2 commits December 27, 2024 21:22

Merge branch 'MAIN-B-21507_POD-POE_TOO_Validation' into INT-B-21507_P…

d8ab755

…OD-POE_TOO_Validation

Merge pull request #14476 from transcom/MAIN-B-22139

c6ae1bf

MAIN B-22139

brianmanley-caci reviewed Dec 27, 2024

View reviewed changes

src/utils/shipmentDisplay.jsx Outdated Show resolved Hide resolved

brianmanley-caci reviewed Dec 27, 2024

View reviewed changes

msaki-caci added 6 commits December 27, 2024 21:53

B-21507

68bec57

Refactor how dashes are shown for empty POD or POE

Merge branch 'MAIN-B-21507_POD-POE_TOO_Validation' into INT-B-21507_P…

77f9893

…OD-POE_TOO_Validation

B-21507

7bc337a

Rename Embark and Debark to Embarkation and Debarkation

B-21507

8fb5a07

Refactor test for change of POE/POD header

Merge branch 'MAIN-B-21507_POD-POE_TOO_Validation' into INT-B-21507_P…

ee8590e

…OD-POE_TOO_Validation

B-21507

ab935f2

Remove unnecessary swagger definition for Port

msaki-caci added 3 commits December 27, 2024 22:30

Merge branch 'MAIN-B-21507' into branch INT-B-21507

25c6790

Merge branch 'main' into MAIN-B-21507_POD-POE_TOO_Validation

58756ab

Merge branch 'MAIN-B-21507' into branch INT-B-21507

972d411

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Int b 21507 pod poe too validation #14475

Int b 21507 pod poe too validation #14475

msaki-caci commented Dec 26, 2024 •

edited

Loading

brianmanley-caci Dec 27, 2024

msaki-caci Dec 27, 2024

brianmanley-caci Dec 27, 2024

msaki-caci Dec 27, 2024

msaki-caci Dec 27, 2024

brianmanley-caci Jan 2, 2025

brianmanley-caci Dec 27, 2024

josiahzimmerman-caci commented Dec 27, 2024

msaki-caci commented Dec 27, 2024

Int b 21507 pod poe too validation #14475

Are you sure you want to change the base?

Int b 21507 pod poe too validation #14475

Conversation

msaki-caci commented Dec 26, 2024 • edited Loading

Summary

Verification Steps for the Author

Verification Steps for Reviewers

Setup to Run the Code

How to test

Frontend

Backend

Screenshots

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

josiahzimmerman-caci commented Dec 27, 2024

msaki-caci commented Dec 27, 2024

msaki-caci commented Dec 26, 2024 •

edited

Loading