Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INT - B-21687 - Inconsistent Design Multiple Tags #14461

Open
wants to merge 4 commits into
base: integrationTesting
Choose a base branch
from

Conversation

taeJungCaci
Copy link
Contributor

@taeJungCaci taeJungCaci commented Dec 23, 2024

B-21687

Summary

This is to change how Tags look in the app and how it is displayed in the shipment cards.

  • Tag component now has border radius of 2em.
  • DIVERSION and DIVERSION REQUESTED tags are now in light orange/gold.
  • CANCELLATION REQUESTED tag is now in same color as CANCELLED which is light red.
  • PPM status tags such as WAITING FOR CUSTOMER or PACKET READY FOR DOWNLOAD are now in light green.
  • All the tags in the shipment card now have the same font size.
  • Updated tags in EvaluationReportShipmentDisplay to similarly match other shipment card displays.

How to test

  1. Create a move with a HHG and a PPM.
  2. Complete counseling as a SC and submit.
  3. Either manually activate each tags shown in the screenshot to verify or go to src/components/Office/ShipmentDisplay/ShipmentDisplay.jsx and delete all the conditional checks related to Tag component below line # 99. Do the same for other areas of the app and verify the colors and rounded edges match the screenshot.
  4. This story focuses on the shipment cards, but since the rounded edges have been added to all the Tag - verify nothing looks out of the norm.

Screenshots

image
image
image
image

@taeJungCaci taeJungCaci added ByteSize M&Ms Team ByteSized M&Ms INTEGRATION Slated for Integration Testing labels Dec 23, 2024
@taeJungCaci taeJungCaci self-assigned this Dec 23, 2024
@robot-mymove
Copy link

Warnings
⚠️

Files located in legacy directories (src/shared or src/scenes) have
been edited. Are you sure you don’t want to also relocate them to the new file structure?

View the frontend file org ADR for more information

⚠️ This PR does not include changes to unit tests, even though it affects app code.

Generated by 🚫 dangerJS against a3e0891

@taeJungCaci taeJungCaci marked this pull request as ready for review December 23, 2024 19:24
@taeJungCaci taeJungCaci requested review from a team as code owners December 23, 2024 19:24
@taeJungCaci taeJungCaci marked this pull request as draft December 26, 2024 15:34
@taeJungCaci taeJungCaci marked this pull request as ready for review January 2, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ByteSize M&Ms Team ByteSized M&Ms INTEGRATION Slated for Integration Testing
Development

Successfully merging this pull request may close these issues.

3 participants