Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B 21336 int Add bulk assignment button and modal creation #14457

Open
wants to merge 12 commits into
base: integrationTesting
Choose a base branch
from

Conversation

JonSpight
Copy link
Contributor

Agility ticket

Summary

Create new feature flag called "FEATURE_FLAG_BULK_ASSIGNMENT."
Add a feature flagged button to the SC/TOO/TIO queues, only visible to supervisors.
Clicking the button will open a Bulk Assignment modal with just the Title, Save and Cancel button.

How to test

1.With the FEATURE_FLAG_BULK_ASSIGNMENT OFF Check the SC/TOO/TIO and verify the bulk assignment Button is not visible
2. Turn the FEATURE_FLAG_BULK_ASSIGNMENT ON and create a TOO/SC/TIO all without supervisor privileges
3. check the SC/TOO/TIO queues and verify the bulk assignment button is not visible
4. create a TOO/SC/TIO all with supervisor privileges
5. check the SC/TOO/TIO queues and verify the bulk assignment button is visible
6. Click the bulk assignment button and verify the bulk assignment modal pops up with a title save and cancel button

Screenshots

@JonSpight JonSpight changed the title B 21336 int B 21336 int Add bulk assignment button and modal creation Dec 21, 2024
@robot-mymove
Copy link

robot-mymove commented Dec 21, 2024

Warnings
⚠️

Files located in legacy directories (src/shared or src/scenes) have
been edited. Are you sure you don’t want to also relocate them to the new file structure?

View the frontend file org ADR for more information

Generated by 🚫 dangerJS against deea711

@JonSpight JonSpight self-assigned this Dec 23, 2024
@JonSpight JonSpight added G-Unit Scrum Team G INTEGRATION Slated for Integration Testing frontend labels Dec 23, 2024
@JonSpight JonSpight marked this pull request as ready for review December 23, 2024 15:10
@JonSpight JonSpight requested review from a team as code owners December 23, 2024 15:10
Copy link
Contributor

@ryan-mchugh ryan-mchugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment still outstanding. The rest have been resolved!

src/pages/Office/index.jsx Outdated Show resolved Hide resolved
@ryan-mchugh
Copy link
Contributor

2 Happo diffs showing that are not related to this story??

@pambecker
Copy link
Contributor

Have you created the file changes to checkin for the FF into the milmove-feature-flags repo? if so, can you link it here.

Copy link
Contributor

@pambecker pambecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HQ supervisor should not see this Bulk Assignment button at any time.

@pambecker
Copy link
Contributor

pambecker commented Dec 31, 2024

HQ supervisor should not see this Bulk Assignment button at any time.

well, disregard, for some reason when I created my HQ role, it also gave me an SC role, and that's what I was seeing. This is working as expected for the HQ role.

@pambecker pambecker self-requested a review December 31, 2024 01:39
@ryan-mchugh
Copy link
Contributor

The "Destination Requests" queue for the TOO was added this PI. From a quick search on VersionOne, I do not see any AC in those stories for the bulk assignment addition.

Wanted to make sure you're aware and can coordinate with Mountain Movers on the original feature for the queue E-05336, or Go-Rillaz for the related "assigned column" OBE feature E-06095.

Destination Requests queue
image

@ryan-mchugh
Copy link
Contributor

Tested and all matches up to the testing steps.
(NOTE - "Destination Requests" queue does not show button)

@paulstonebraker
Copy link
Contributor

The "Destination Requests" queue for the TOO was added this PI. From a quick search on VersionOne, I do not see any AC in those stories for the bulk assignment addition.

Wanted to make sure you're aware and can coordinate with Mountain Movers on the original feature for the queue E-05336, or Go-Rillaz for the related "assigned column" OBE feature E-06095.

Destination Requests queue image

Good call - will make a note to chat with team about it during team sync tomorrow, or later this week if tomorrow's team sync is sparsely attended

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend G-Unit Scrum Team G INTEGRATION Slated for Integration Testing
Development

Successfully merging this pull request may close these issues.

6 participants