B-21533 HQ role with Safety Move privs #14454
Open
+487
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-mettler
requested review from
MInthavongsay,
antgmann,
ajlusk,
CoryKleinjanCACI and
a team
|
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded
Removed
Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
danieljordan-caci
approved these changes
Dec 20, 2024
Test coverage on server failed.Last run: Fri 20 Dec 2024 09:01:51 PM UTC |
antgmann
approved these changes
Dec 27, 2024
Test coverage on client failed.Last run: Fri 27 Dec 2024 03:48:31 PM UTC |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
B-21533
INT PR
Summary
Previously code was added to prevent HQ role from being able to have Safety Move privileges, but it was decided that HQ should now have access to see Safety Moves. This PR removes the checks preventing the HQ role from selecting the Safety Move priv in the admin console.
Verification Steps for the Author
These are to be checked by the author.
Verification Steps for Reviewers
These are to be checked by a reviewer.
Setup to Run the Code
How to test
To be able to select Safety Moves you need to first add the Super permissions for the admin account. This can be done by changing the flag in the DB for
superto true in theadmin_userstable.Now you can either edit and existing Office User and give them Headquarters Role and Safety Move privileges or create a new Office User with the HQ role and Safety Move priv.
NOTE: If creating a new Office User you first must select the HQ role and save and then you can add the Safety Move privilege. This is because the checkbox for Safety Move is only currently available on the edit Office User page and not create page (known issue).
The Safety Moves privilege can only be selected for the following roles: Task Ordering Officer, Task Invoicing Officer, Services Counselor, Quality Assurance Evaluator, Customer Service Representative, and Headquarters
Task Ordering Officer
Task Invoicing Officer
Services Counselor
Quality Assurance Evaluator
Customer Service Representative
Headquarters
Customer
Contracting Officer
Prime Simulator
Government Surveillance Representative
SM)Frontend
officeAppclass or custommin-widthstyling is used to hide any states the would not be visible to the user.