-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
B 21583 int #14451
Open
pambecker
wants to merge
48
commits into
integrationTesting
Choose a base branch
from
B-21583-INT
base: integrationTesting
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
B 21583 int #14451
+719
−133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pambecker
requested review from
paulstonebraker,
loganwc,
joeydoyecaci and
JonSpight
December 27, 2024 20:40
pkg/models/duty_location.go
Outdated
oconusGbloc := oconusGbloc{} | ||
|
||
sqlQuery := ` | ||
select j.code gbloc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
non blocking comment but it would make my brain happy if we could make the sql commands UPPERCASE 🤓
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
B-21976 Check feature flag for NTS/NTSR in office app
B 21819 prime 3rd address errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Agility ticket
Summary
When a move is created that has an Alaska duty location, we need to make it so it routes to the right GBLOC for that zone.
Needs to route through SC, TOO, TIO and show in the correct GBLOC for each queue.
How to test
Zones:
SQL to run for zone/gbloc on addresses:
select j.code gbloc, j.name jppso, r.code rate_area, r.name rate_area_name, g.department_indicator, g.shipment_type
from addresses a, v_locations v, re_oconus_rate_areas o, re_rate_areas r, jppso_regions j, gbloc_aors g
where a.id = 'put_your_addr_id_here'
and a.us_post_region_cities_id = v.uprc_id
and v.uprc_id = o.us_post_region_cities_id
and o.rate_area_id = r.id
and o.id = g.oconus_rate_area_id
and j.id = g.jppso_regions_id;