Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B 21557 INT find Estimated price when shipment is updated with an estimated weight where there isn't one previously #14448

Open
wants to merge 16 commits into
base: integrationTesting
Choose a base branch
from

Conversation

joeydoyecaci
Copy link
Contributor

@joeydoyecaci joeydoyecaci commented Dec 19, 2024

B-21557

Summary

Updates the price estimates on service items where an estimated weight wasn't initially provided.

How to test

  1. run make tasks_save_ghc_fuel_price_data so that the FSC service items will have the prerequisite data needed to calculate pricing on these items.
  2. Create a move as an HHG shipment, or find an existing move that is already approved
  3. As a SC add an HHG shipment to the move. but do not add an estimated weight
  4. Verify on the move task order tab that the service items are added, leave the tab open
  5. Open a separate tab and find the move as a prime user
  6. update the new mto shipment within the move with an estimated weight
  7. back on the SC tab, refresh the mto shipment tab, the prices should now show next to the service items

@joeydoyecaci joeydoyecaci marked this pull request as ready for review December 19, 2024 22:53
@joeydoyecaci joeydoyecaci requested review from a team as code owners December 19, 2024 22:53
@traskowskycaci
Copy link
Contributor

traskowskycaci commented Dec 20, 2024

B-21557

Summary

Updates the price estimates on service items where an estimated weight wasn't initially provided.

How to test

  1. Create a move as an HHG shipment, or find an existing move that is already approved
  2. As a SC add an HHG shipment to the move. but do not add an estimated weight
  3. Verify on the move task order tab that the service items are added, leave the tab open
  4. Open a separate tab and find the move as a prime user
  5. update the new mto shipment within the move with an estimated weight
  6. back on the SC tab, refresh the mto shipment tab, the prices should now show next to the service items

Can you update the testing instructions to include running make tasks_save_ghc_fuel_price_data? If this isn't run, those testing won't see a price for the Fuel Surcharge (FSC) service item

@joeydoyecaci
Copy link
Contributor Author

B-21557

Summary

Updates the price estimates on service items where an estimated weight wasn't initially provided.

How to test

  1. Create a move as an HHG shipment, or find an existing move that is already approved
  2. As a SC add an HHG shipment to the move. but do not add an estimated weight
  3. Verify on the move task order tab that the service items are added, leave the tab open
  4. Open a separate tab and find the move as a prime user
  5. update the new mto shipment within the move with an estimated weight
  6. back on the SC tab, refresh the mto shipment tab, the prices should now show next to the service items

Can you update the testing instructions to include running make tasks_save_ghc_fuel_price_data? If this isn't run, those testing won't see a price for the Fuel Surcharge (FSC) service item

Done!

traskowskycaci
traskowskycaci previously approved these changes Dec 26, 2024
Copy link
Contributor

@traskowskycaci traskowskycaci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing estimated prices when prime provides estimated weight for HHGs:
image

Also seeing prices on an NTS-R shipment:
image

@danieljordan-caci
Copy link
Contributor

Is there a reason this BL is estimated at 13 points? Is that an accurate LOE? That seems super inflated.

@joeydoyecaci
Copy link
Contributor Author

Is there a reason this BL is estimated at 13 points? Is that an accurate LOE? That seems super inflated.

It was meant to be much lower, there were some complications with getting the unit tests to work specifically for UpdateShipment.

@joeydoyecaci joeydoyecaci added the INTEGRATION Slated for Integration Testing label Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
G-Unit Scrum Team G INTEGRATION Slated for Integration Testing
Development

Successfully merging this pull request may close these issues.

4 participants