Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow multiple paths with --filter flag #264

Conversation

rsinnet
Copy link

@rsinnet rsinnet commented Dec 23, 2022

Pull Request

Related Github Issues

  • [none]

Description

Update the type of the --filter flag so multiple paths or glob expressions can be passed as a comma-separated list.

Security Implications

  • [none]

System Availability

  • [none]

@rsinnet rsinnet changed the title Allow multiple paths with --filter flag feat: Allow multiple paths with --filter flag Dec 23, 2022
Update the type of the --filter flag so multiple paths or glob
expressions can be passed as a comma-separated list.
@rsinnet rsinnet force-pushed the user/rsinnet/add-multiple-filter-paths branch from 27cea2e to 5cfdc3e Compare December 23, 2022 00:50
@rsinnet
Copy link
Author

rsinnet commented Mar 4, 2023

Do I need to do anything to get this assigned?

@rsinnet rsinnet closed this Dec 2, 2023
@rsinnet rsinnet reopened this Dec 2, 2023
@amontalban
Copy link
Contributor

I really need this feature 🙏

@dmattia what is needed to have this merged? Thank you!

@Almenon
Copy link
Collaborator

Almenon commented Apr 13, 2024

@amontalban I reviewed the code and it looks good. I still need to pass it by chatgpt. The code fails a few tests when I run it locally on Windows. It's been a long time since this PR was created, so the PR will need to be rebased on top of master and any test failures fixed. I would wait a bit* to see if @rsinnet will take this on, otherwise you can create your own PR.

* wait time depending on how patient you are, I would suggest a day at least

@rsinnet
Copy link
Author

rsinnet commented Apr 13, 2024

@amontalban I reviewed the code and it looks good. I still need to pass it by chatgpt. The code fails a few tests when I run it locally on Windows. It's been a long time since this PR was created, so the PR will need to be rebased on top of master and any test failures fixed. I would wait a bit* to see if @rsinnet will take this on, otherwise you can create your own PR.

image

  • wait time depending on how patient you are, I would suggest a day at least

Sorry, guys. I left the organization and no longer have push access to the branch. Maybe @shaurya-pednekar or @imjaya can help out here?

@Almenon
Copy link
Collaborator

Almenon commented Apr 13, 2024

The code fails a few tests when I run it locally on Windows

Ignore this part, my bad. This was because #311 was not merged in yet. Once I merged it in all the tests passed with a copy-pasted set of your changes 🎉 . The PR will still need to be rebased or recreated to make sure the tests pass in CI.

@amontalban
Copy link
Contributor

The code fails a few tests when I run it locally on Windows

Ignore this part, my bad. This was because #311 was not merged in yet. Once I merged it in all the tests passed with a copy-pasted set of your changes 🎉 . The PR will still need to be rebased or recreated to make sure the tests pass in CI.

@Almenon created #328 with latest master code.

Thank you for checking this out!

@Almenon
Copy link
Collaborator

Almenon commented Apr 21, 2024

I just merged in the new PR, closing. Thanks for the contribution!

@Almenon Almenon closed this Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants